Skip to content
This repository was archived by the owner on Feb 5, 2021. It is now read-only.

[ISSUE-10] Including container ip in service instance at discovery time#11

Open
qzagarese wants to merge 22 commits intomasterfrom
ISSUE-10
Open

[ISSUE-10] Including container ip in service instance at discovery time#11
qzagarese wants to merge 22 commits intomasterfrom
ISSUE-10

Conversation

@qzagarese
Copy link
Copy Markdown
Contributor

No description provided.

DarthSeppius
DarthSeppius previously approved these changes Jun 20, 2019
.withIp(DOCKER_HOST)
.withGatewayIp(DOCKER_HOST)
.withContainerName(r.getName())
.withContainerIp(ContainerUtils.extractBridgeIpAddress(r.getNetworkSettings()).orElse(""))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind to give this a shot of auto-format? thanks.

irotech
irotech previously approved these changes Jun 21, 2019
@qzagarese qzagarese dismissed stale reviews from irotech and DarthSeppius via 96639ac July 11, 2019 11:56
@pnsantos
Copy link
Copy Markdown
Contributor

@qzagarese needs a rebase

pnsantos
pnsantos previously approved these changes Jan 25, 2021
qzagarese and others added 20 commits January 25, 2021 15:28
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
…ewayPort for service instances

Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
Signed-off-by: pnsantos <pnuno.santos@gmail.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
Signed-off-by: pnsantos <pnuno.santos@gmail.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
- Move a couple of section to parent pom (inherited)
- Inherit the parent pom version and groupId
- Add jacoco and surefire to build (still no tests though)
- Bump lombok to 1.18.3
- Add snapshot repo (so checkout+build requires no config)

Signed-off-by: pnsantos <pnuno.santos@gmail.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
Signed-off-by: pnsantos <pnuno.santos@gmail.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
Signed-off-by: pnsantos <pnuno.santos@gmail.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
Signed-off-by: pnsantos <pnuno.santos@gmail.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
Signed-off-by: pnsantos <pnuno.santos@gmail.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
Signed-off-by: pnsantos <pnuno.santos@gmail.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
- In the version of lombok 1.16.18 there was an annotation that was used on the created ctors that is @ConstructorProperties.
  This annotation was used by jackson for serializating correctly the object, but in the new version of lombok, that is 1.18.8 that was not generated anymore.
  For this reason the serialization of the object ServiceRecord, without an empty ctor, was failing.

  Thanks to Iker that spotted that during the tests!

Signed-off-by: fsorice <fsorice89@gmail.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
Bumps [docker-java](https://github.com/docker-java/docker-java) from 3.1.3 to 3.1.5.
- [Release notes](https://github.com/docker-java/docker-java/releases)
- [Changelog](https://github.com/docker-java/docker-java/blob/master/CHANGELOG.md)
- [Commits](docker-java/docker-java@3.1.3...3.1.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
Bumps httpcore from 4.4.10 to 4.4.11.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
Signed-off-by: fsorice <fsorice89@gmail.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
Bumps [lombok](https://github.com/rzwitserloot/lombok) from 1.18.8 to 1.18.16.
- [Release notes](https://github.com/rzwitserloot/lombok/releases)
- [Changelog](https://github.com/rzwitserloot/lombok/blob/master/doc/changelog.markdown)
- [Commits](projectlombok/lombok@v1.18.8...v1.18.16)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
Signed-off-by: pnsantos <pnuno.santos@gmail.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
- Updated lombok, http-core, and jackson dependencies;
- Bumped the version of the module to `0.1.1`.

Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
Signed-off-by: qzagarese <quirino.zagarese@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants